test(datetime): improve test coverage #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4649 +/- ##
==========================================
+ Coverage 91.02% 91.37% +0.34%
==========================================
Files 478 478
Lines 37336 37342 +6
Branches 5298 5325 +27
==========================================
+ Hits 33985 34121 +136
+ Misses 3289 3160 -129
+ Partials 62 61 -1 ☔ View full report in Codecov by Sentry. |
iuioiua
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working towards #3713.
pushes code coverage of the
datetimesub-module closer to 100%.currently only misses:
dateTimeFormatter.format(), which is tagged asFIXMEdateTimeFormatter.partsToDate(), where the local the format doesn't contain a day and the timezone isn't utc