Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(uuid): format test names and improve test coverage #4002

Merged
merged 2 commits into from
Dec 20, 2023
Merged

refactor(uuid): format test names and improve test coverage #4002

merged 2 commits into from
Dec 20, 2023

Conversation

babiabeo
Copy link
Contributor

@babiabeo babiabeo commented Dec 20, 2023 •
edited
Loading

Ref: #3713, #3754

This PR updates the test names as well as improving the test coverage in uuid.

See: https://app.codecov.io/gh/denoland/deno_std/pull/4002/tree/uuid

@babiabeo babiabeo requested a review from kt3k as a code owner December 20, 2023 13:59
@github-actions github-actions bot added the uuid label Dec 20, 2023
iuioiua
iuioiua approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the version prefixes from the test names, as we can tell which UUID version we're testing from the file name.

Either way, LGTM! Thank you for this.

@iuioiua iuioiua merged commit 29015d2 into denoland:main Dec 20, 2023
12 checks passed
@babiabeo babiabeo deleted the improve-uuid-test branch December 20, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
uuid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babiabeo @iuioiua