Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fs): improve exists() test coverage #3898

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix(fs): improve exists() test coverage #3898

merged 2 commits into from
Dec 5, 2023

Conversation

vasucp1207
Copy link
Contributor

Issue #3713

New test cases cover,

  • When both isDirectory and isFile set to true.
    • When user is the owner and can read.
  • When user group is the owner and can read.

@vasucp1207 vasucp1207 requested a review from kt3k as a code owner December 5, 2023 19:25
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the fs label Dec 5, 2023
@iuioiua iuioiua changed the title fix(test): improve fs.exists test coverage fix(fs): improve exists() test coverage Dec 5, 2023
iuioiua
iuioiua approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution.

@iuioiua iuioiua merged commit 9a55a6e into denoland:main Dec 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasucp1207 @CLAassistant @iuioiua