Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: speed up v8::String::to_rust_*_lossy() #1645

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf: speed up v8::String::to_rust_*_lossy() #1645

wants to merge 3 commits into from
+380 −146

Commits on Oct 18, 2024

  1. perf: speed up v8::String::to_rust_*_lossy() 

    This commit speeds up this common conversion
method between by 2x for many common cases. Short
one byte ASCII strings are now 20% faster. Longer
one byte ASCII strings are 2.5x faster. Short UTF8
strings are marginally slower (5%) but longer UTF8
strings are upwards of 2x faster.

A follow up will make the short UTF8 strings about
2x faster than the current implementation as well.
    @lucacasonato
    lucacasonato committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    db693c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. try

    @lucacasonato
    lucacasonato committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5b2734d View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. add method to ValueView

    @lucacasonato
    lucacasonato committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1eba610 View commit details
    Browse the repository at this point in the history