-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upgrade check #1444
feat: add upgrade check #1444
Conversation
a06d7ec
to
a75b59f
Compare
2d45495
to
1ade420
Compare
cbd0d15
to
43ea269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Few nits.
import { colors, dirname, join } from "./deps.ts"; | ||
|
||
interface CheckFile { | ||
last_checked: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this being a Date
or even just a number
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would we gain by changing it? This is an update check and this file isn't used for anything else. Benefits of keeping this an ISO string is that it's human readable.
Co-authored-by: Asher Gomez <[email protected]>
fa306f5
to
342f52e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds an upgrade check to notify users of a Fresh version. The check is done once per day.
This is how it looks like.