Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimum required Deno version to 1.46.0 and cleanup #332

Merged
merged 46 commits into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
b2f279b
remove vendor
magurotuna Oct 16, 2024
0689f2f
import denosaurs packages from jsr
magurotuna Oct 16, 2024
d7f7a1a
add @std/fmt to import map
magurotuna Oct 16, 2024
22b0a41
add @std/path to import map
magurotuna Oct 16, 2024
7154bc2
add @std/flags to import map
magurotuna Oct 16, 2024
64a2377
add @std/streams to import map
magurotuna Oct 16, 2024
39cf61e
add @std/jsonc to import map
magurotuna Oct 16, 2024
9a5634b
add @std/encoding to import map
magurotuna Oct 16, 2024
3d9ab89
add @std/async to import map
magurotuna Oct 16, 2024
da97769
add @std/dotenv to import map
magurotuna Oct 16, 2024
5883f7b
add @std/semver to import map
magurotuna Oct 16, 2024
400009e
add @denosaurs/wait to import map
magurotuna Oct 16, 2024
c326a14
add @denosaurs/tty to import map
magurotuna Oct 16, 2024
0b73a8b
remove deps.ts
magurotuna Oct 16, 2024
1a4df3d
add @std/assert to import map
magurotuna Oct 16, 2024
1cd3f83
fix import source in test files
magurotuna Oct 16, 2024
121b51c
support printing errors of unknown type
magurotuna Oct 16, 2024
0dd25b5
handle errors of unknown type
magurotuna Oct 16, 2024
9b3b9fa
fix isTerminal function
magurotuna Oct 16, 2024
7895e15
Remove our own `isTerminal` function
magurotuna Oct 16, 2024
702b3bb
add comment
magurotuna Oct 16, 2024
04747d3
format
magurotuna Oct 18, 2024
ab2e045
bump minimum required version to 1.46.0 (to use lockfile v4)
magurotuna Oct 18, 2024
f257e12
use 2.x of Deno as a stable version in CI
magurotuna Oct 18, 2024
322cf74
update deno.lock
magurotuna Oct 18, 2024
0b962ca
fix bundle.ts
magurotuna Oct 18, 2024
3139152
force @deno/emit to use @deno/[email protected] to get bundling to work
magurotuna Oct 18, 2024
f66eaa9
run deno task build-action
magurotuna Oct 18, 2024
084d92b
remove vendor from exclude list as vendor is no longer there
magurotuna Oct 18, 2024
fdfb480
enable DENO_FUTURE when in v1.46
magurotuna Oct 18, 2024
107302f
run deno cache as a workaround
magurotuna Oct 18, 2024
6ba4405
bump minimum required version to 2.0.0 (as bundle does not work in v1)
magurotuna Oct 18, 2024
ba503dc
format
magurotuna Oct 18, 2024
a0882d6
import process
magurotuna Oct 18, 2024
70b0fc8
try to decrease minimum deno version to 1.46.0 again
magurotuna Oct 18, 2024
798a29f
use ubuntu-latest
magurotuna Oct 18, 2024
0bc0ed3
update minimum required Deno version in README.md
magurotuna Oct 18, 2024
4ab48d3
do not append newline when cause is not available
magurotuna Oct 18, 2024
c8593da
run deno task build-action
magurotuna Oct 18, 2024
599021d
try --no-lock (not works, because help_test spawns another deno process)
magurotuna Oct 18, 2024
2ee0829
Revert "try --no-lock (not works, because help_test spawns another de…
magurotuna Oct 18, 2024
fd59d23
add verbose option to stringify function
magurotuna Oct 18, 2024
54092f5
enable verbose if program stops with that error
magurotuna Oct 18, 2024
8cf317b
run deno task build-action
magurotuna Oct 18, 2024
3e0d9a0
append --no-lock flag when running tests in Deno 1.x
magurotuna Oct 21, 2024
b63d497
need to pass tests on ubuntu-22.04-xl to satisfy GH status checker...
magurotuna Oct 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ jobs:
matrix:
# Test on the oldest supported, the latest stable, and nightly
deno: [old, stable, canary]
os: [macOS-latest, windows-latest, ubuntu-22.04-xl]
os: [macOS-latest, windows-latest, ubuntu-latest]

env:
DENO_FUTURE: ${{ matrix.deno == 'old' && '1' || '0' }}
arnauorriols marked this conversation as resolved.
Show resolved Hide resolved

steps:
- name: Setup repo
Expand All @@ -24,7 +27,8 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v1
with:
deno-version: ${{ matrix.deno == 'old' && '1.41.1' || (matrix.deno == 'stable' && '1.x' || matrix.deno) }}
# Make sure to keep this in sync with the one defined in version.ts
deno-version: ${{ matrix.deno == 'old' && '1.46.0' || (matrix.deno == 'stable' && '2.x' || matrix.deno) }}

- run: deno --version

Expand All @@ -40,10 +44,14 @@ jobs:
if: runner.os == 'Linux' && matrix.deno == 'stable'
run: deno check deployctl.ts

- name: Run tests
run: deno task test

- name: action/deps.js up-to-date
if: runner.os == 'Linux' && matrix.deno == 'stable'
run: |
# @deno/emit doesn't work if JSR modules are not in the cache.
# This is a workaround to cache the JSR modules beforehand.
deno cache ./src/utils/mod.ts
deno run --allow-read --allow-env --allow-net ./tools/bundle.ts ./src/utils/mod.ts > ./action/latest.deps.js
diff ./action/latest.deps.js ./action/deps.js

- name: Run tests
run: deno task test
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,21 @@ jobs:
root: action/tests
entrypoint: include_exclude.ts
include: include_exclude.ts
- name: Deploy with comma-separated include
- name: Deploy with comma-separated include
uses: ./
with:
project: happy-rat-64
root: action
entrypoint: tests/include_exclude.ts
include: foo,tests/include_exclude.ts,bar
- name: Deploy with comma-separated exclude
- name: Deploy with comma-separated exclude
uses: ./
with:
project: happy-rat-64
root: action/tests
entrypoint: include_exclude.ts
exclude: import_bomb1,import_bomb2
- name: Deploy with multiline exclude
- name: Deploy with multiline exclude
uses: ./
with:
project: happy-rat-64
Expand Down Expand Up @@ -74,4 +74,4 @@ jobs:
with:
project: happy-rat-64
root: action/tests
entrypoint: always_exclude_node_modules/main.ts
entrypoint: always_exclude_node_modules/main.ts
2 changes: 1 addition & 1 deletion action/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
id-token: write # required
contents: read
steps:
# your steps here...
# your steps here...
```

### Inputs
Expand Down
Loading
Loading