-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(action): always print x-deno-ray for debuggability #321
Merged
magurotuna
merged 14 commits into
denoland:main
from
magurotuna:always-print-x-deno-ray-on-action
Aug 15, 2024
Merged
feat(action): always print x-deno-ray for debuggability #321
magurotuna
merged 14 commits into
denoland:main
from
magurotuna:always-print-x-deno-ray-on-action
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Aug 14, 2024
kt3k
reviewed
Aug 14, 2024
kt3k
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
x-deno-ray
values always printed in GitHub Actions as soon as we get a response from the backend API server.The primary motivation behind it is that it's hard to debug issues with streaming APIs - in particular,
gitHubActionsDeploy
:deployctl/src/utils/api.ts
Lines 410 to 424 in acb2ba3
This API returns 200 OK and then starts streaming the progress. But currently
x-deno-ray
is not printed when the status code is 200. Problems that happen during streaming, e.g. very slow file uploads, could be made easier to debug by makingx-deno-ray
available in this case too.