Feat: Support include/exclude in github action #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't tested this yet.
|
|
|
Still waiting on this, this would be great. |
arnauorriols
reviewed
Nov 3, 2023
action/index.js
Outdated
| @@ -72,8 +75,8 @@ async function main() { | |||
| core.debug(`Discovering assets in "${cwd}"`); | |||
| const assets = new Map(); | |||
| const entries = await walk(cwd, cwd, assets, { | |||
| include: undefined, | |||
| exclude: undefined, | |||
| include: include ? include.split(",").map(pattern => normalize(pattern)): undefined, | |||
There was a problem hiding this comment.
Newline separated strings is the defacto-standard workaround to express arrays in GH action parameters. core.getMultilineInput() handles splitting and trimming for you.
It's preferrable as there might be array parameters we want to add in the future that might not play as well with the comma-separated approach.
|
Thank you so much for your contribution @osdiab, and appologies for taking so long to get our attention to it! I'm going to merge it now. |
arnauorriols
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this yet.OK I think this is working? but the display of how many bytes it's uploading seems to be wrong, always says0 byteson my project now when I have this, but the deploys are working much faster now that I can declare what to include/exclude. It does appear to work!Resolves #100
Resolves #171
Resolves #181