Fix: Data URL entrypoints (#333)

denoland · Oct 22, 2024 · 51c3243 · 51c3243
1 parent bd19482
commit 51c3243
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -75,3 +75,9 @@ jobs:
           project: happy-rat-64
           root: action/tests
           entrypoint: always_exclude_node_modules/main.ts
+      - name: data URL entrypoint
+        uses: ./
+        with:
+          project: happy-rat-64
+          root: action/tests
+          entrypoint: "data:,Deno.serve(() => new Response())"
diff --git a/action/deps.js b/action/deps.js
@@ -771,7 +771,7 @@ async function parseEntrypoint(entrypoint, root, diagnosticName = "entrypoint")
     return entrypointSpecifier;
 }
 function isURL(entrypoint) {
-    return entrypoint.startsWith("https://") || entrypoint.startsWith("http://") || entrypoint.startsWith("file://");
+    return entrypoint.startsWith("https://") || entrypoint.startsWith("http://") || entrypoint.startsWith("file://") || entrypoint.startsWith("data:") || entrypoint.startsWith("jsr:") || entrypoint.startsWith("npm:");
 }
 function delay(ms, options = {}) {
     const { signal, persistent } = options;

diff --git a/src/utils/entrypoint.ts b/src/utils/entrypoint.ts
@@ -39,5 +39,8 @@ export async function parseEntrypoint(
 export function isURL(entrypoint: string): boolean {
   return entrypoint.startsWith("https://") ||
     entrypoint.startsWith("http://") ||
-    entrypoint.startsWith("file://");
+    entrypoint.startsWith("file://") ||
+    entrypoint.startsWith("data:") ||
+    entrypoint.startsWith("jsr:") ||
+    entrypoint.startsWith("npm:");
 }