feat: KV Connect protocol spec #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorzi
reviewed
Oct 30, 2023
Comment on lines
+257
to
+259
| The server MAY perform quota checks on the request. If the request is rejected | ||
| due to quota limits, the server MUST respond with a 4xx class response and a | ||
| plain text body containing a human readable error message. |
There was a problem hiding this comment.
I have added a note to the paragraph above about using 5xx responses for rate limiting, as those are retried with backoff.
| exponential backoff strategy with unlimited retries. | ||
|
|
||
| The client MUST verify that the response is a 200 OK response. If the response | ||
| is a 4xx class error response, the client MUST fatally abort the request and |
There was a problem hiding this comment.
Similar comment to above about rate limiting. Should the server be able to respond with 429? and should the client interpret that as retry with backoff?
There was a problem hiding this comment.
I think the server should respond with a 503 then. It's easier if 4xx == never retry, and 5xx == retry with backoff.
There was a problem hiding this comment.
I think there should be a mechanism to "gracefully" rate limit, like starting to throttle at 90% of the limit and when it reaches 100% wait until the end of the rate limit window
igorzi
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a proper spec for the KV Connect protocol.