Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add devcontainer #1127

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: add devcontainer #1127

wants to merge 3 commits into from

Conversation

LeoDog896
Copy link

@LeoDog896 LeoDog896 commented Feb 3, 2023

adds a devcontainer with Deno (for www) and Rust (for the repo itself) support.

(If a contributor agrees) I do also think that the perf tools should be added as well (as mentioned in README), but for now it's a bare container.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the useful configuration!
Could you add .devcontainer directory to the format target in tools/format.ts, so deno fmt will be applied to devcontainer.json?
Like this:

const p3 = await Deno.run({
  cmd: [
    "deno",
    "fmt",
    ...checkArgs,
    "tools",
    "benchmarks/benchmarks.ts",
    "www/pages",
    "docs/rules",
    "README.md",
+   ".devcontainer",
  ],
  stdin: "null",
}).status();

Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also don't remember to run the formatter so the CI passes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants