refactor: parse pragmas with monch #224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change: no longer parses @deno-types without quotes
… this and it creates complexity in the ecosystem
dsherret
changed the title
dsherret
commented
Apr 18, 2024
| let (input, _) = ch('=')(input)?; | ||
| let quote_start_input = input; | ||
| let (input, quote_char) = or(ch('"'), ch('\"'))(input)?; | ||
| let (input, text) = take_while(|c| c != quote_char)(input)?; |
There was a problem hiding this comment.
This would go across newlines, which is not good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses
@deno-typeswith monch because this parsing is done often and using monch is slightly faster. As part of this change, not providing quotes no longer works. This is because it creates more complexity for scenarios to support and it seems like less than 5 public repos are affected. If we do this, I'll open PRs to the affected repos.