Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename op2 to op #808

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

littledivy
Copy link
Member

It has stayed op2 for a long time now with older op macro removed

It has stayed op2 for a long time now with older op macro removed
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 70.90164% with 71 lines in your changes missing coverage. Please review.

Project coverage is 81.75%. Comparing base (0c7f83e) to head (732d2e4).
Report is 50 commits behind head on main.

Files Patch % Lines
core/runtime/ops.rs 76.40% 21 Missing ⚠️
core/ops_builtin_v8.rs 56.09% 18 Missing ⚠️
core/ops_builtin.rs 37.03% 17 Missing ⚠️
testing/checkin/runner/ops.rs 20.00% 8 Missing ⚠️
ops/op/mod.rs 78.57% 3 Missing ⚠️
testing/checkin/runner/ops_error.rs 66.66% 2 Missing ⚠️
core/extensions.rs 0.00% 1 Missing ⚠️
ops/lib.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   81.43%   81.75%   +0.32%     
==========================================
  Files          97       98       +1     
  Lines       23877    24324     +447     
==========================================
+ Hits        19445    19887     +442     
- Misses       4432     4437       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/ci-test/action.yml:        cargo run -p deno_core --example op2
.github/workflows/ci-test/action.yml:        cargo run -p deno_core --example op2 --features include_js_files_for_snapshotting
core/examples/op2.rs:  esm_entry_point = "ext:op_sample/op2.js",
core/examples/op2.rs:  esm = [ dir "examples", "op2.js" ],

Can you update the following instances?

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of renaming, but I guess that's okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants