perf: Batch calls to ModuleLoader::prepare_load
for dynamic imports
#761
+131
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collects dynamic imports between event loop ticks and then calls
prepare_load
with the collected imports. This reduces the number of calls toprepare_load
.Performance impact on deno is noticeable but relatively modest, around 6-7%:
My main concern here is the loss of granularity in errors that occur during
prepare_load
. Since we now are callingprepare_load
with multiple specifiers, if the loader returns an error we can't really tell which specifier the error applies to. That results in a visible behavior change for users, for exampleBefore this PR, that would successfully print "Done", currently with this PR it would throw for the import of
"foo.ts"
(even though it didn't actually have an error).