fix(core): prevent panic in to_v8_error

Return the underlying error message instead of panicking with: "Custom error class must have a builder registered: Uncaught null".
denoland · May 13, 2024 · 5f2a1a5 · 5f2a1a5
1 parent c106dd1
commit 5f2a1a5
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/core/error.rs b/core/error.rs
@@ -152,6 +152,10 @@ pub fn to_v8_error<'a>(
       if tc_scope.has_caught() {
         let e = tc_scope.exception().unwrap();
         let js_error = JsError::from_v8_exception(tc_scope, e);
+        // Return underlying error message rather than panicking
+        if js_error.exception_message == "Uncaught null" {
+          return message.into();
+        }
         msg = format!("{}: {}", msg, js_error.exception_message);
       }
       panic!("{}", msg);