feat: new "runtime" compiler option #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Oct 23, 2024
bartlomieju
reviewed
Oct 23, 2024
| ], | ||
| ); | ||
| } else if contains_deno { | ||
| self.insert_libs(options, vec!["deno.ns".to_string()]); |
There was a problem hiding this comment.
This needs to be verified with TSC settings in deno, I think we enable more libs for Deno type checking.
There was a problem hiding this comment.
Sure,
Let me know what other libs we need to set or point me so I find myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new "runtime" Compiler option to support an easier way to configure type checking for other runtimes.
Issue: