Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate error in GlobalHttpCache::set() #63

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: propagate error in GlobalHttpCache::set() #63

merged 1 commit into from
Oct 15, 2024

Conversation

nayeemrmn
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dsherret
dsherret approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird it was doing that. LGTM

@nayeemrmn nayeemrmn merged commit 39d2a50 into denoland:main Oct 15, 2024
5 checks passed
@nayeemrmn nayeemrmn deleted the global-http-cache-set-error branch October 16, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starting Deno language server...Connected to "Visual Studio Code" 1.94.0...Deno has panicked.
4 participants
@nayeemrmn @CLAassistant @dsherret @bartlomieju