feat: ability to provide a checksum for global cache #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Feb 14, 2024
| @@ -46,6 +46,8 @@ export class AuthTokens { | |||
| tokens.push({ type: "bearer", host, token }); | |||
| } | |||
| } else { | |||
| // todo(dsherret): feel like this should error? | |||
| // deno-lint-ignore no-console | |||
There was a problem hiding this comment.
Yeah, that's what I added the todo about. It's weird this code does this. I opened #43 just now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a checksum that is only evaluated for the global cache and not the local one (the vendor folder). This allows people to make modifications to the vendor folder without encountering lockfile errors.