fix(wasm): correct ms to s conversion (#31)

denoland · Aug 17, 2023 · 38557ff · 38557ff
1 parent 14ceeb5
commit 38557ff
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 8 deletions.
diff --git a/lib/snippets/deno_cache_dir-bd7d6e431c0654b5/fs.js b/lib/snippets/deno_cache_dir-bd7d6e431c0654b5/fs.js
@@ -58,8 +58,7 @@ export function atomic_write_file(path, bytes) {
 export function modified_time(path) {
   try {
     const stat = Deno.lstatSync(path);
-    const msToS = 1000;
-    return stat.mtime.getTime() * msToS;
+    return msToS(stat.mtime.getTime());
   } catch (err) {
     if (err instanceof Deno.errors.NotFound) {
       return undefined;
@@ -79,6 +78,9 @@ export function is_file(path) {
 }
 
 export function time_now() {
-  const msToS = 1000;
-  return Date.now() * msToS;
+  return msToS(Date.now());
+}
+
+function msToS(ms) {
+  return Math.round(ms / 1000);
 }
diff --git a/rs_lib/fs.js b/rs_lib/fs.js
@@ -58,8 +58,7 @@ export function atomic_write_file(path, bytes) {
 export function modified_time(path) {
   try {
     const stat = Deno.lstatSync(path);
-    const msToS = 1000;
-    return stat.mtime.getTime() * msToS;
+    return msToS(stat.mtime.getTime());
   } catch (err) {
     if (err instanceof Deno.errors.NotFound) {
       return undefined;
@@ -79,6 +78,9 @@ export function is_file(path) {
 }
 
 export function time_now() {
-  const msToS = 1000;
-  return Date.now() * msToS;
+  return msToS(Date.now());
+}
+
+function msToS(ms) {
+  return Math.round(ms / 1000);
 }
diff --git a/rs_lib/fs.test.ts b/rs_lib/fs.test.ts
@@ -0,0 +1,12 @@
+// Copyright 2018-2022 the Deno authors. All rights reserved. MIT license.
+
+import { time_now } from "./fs.js";
+
+Deno.test("gets correct time", () => {
+  const seconds = time_now();
+  const expected = Math.round(Date.now() / 1000);
+  if (expected != seconds) {
+    console.error("Values:", expected, seconds);
+    throw new Error("Not equal");
+  }
+});