Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fetch): accept async iterables for body #26882

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(fetch): accept async iterables for body #26882

merged 1 commit into from
Nov 15, 2024
+251 −51

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Nov 15, 2024 •
edited
Loading

Reland of #24623, but with a fix for String objects.

Fixes #21454
Closes #24849
Closes #26667

bartlomieju
bartlomieju approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@bartlomieju
Copy link
Member

I think we can mark it as closing #26667.

@lucacasonato lucacasonato merged commit b8cf259 into denoland:main Nov 15, 2024
17 checks passed
@lucacasonato lucacasonato deleted the webidl-async-iterable branch November 15, 2024 14:54
@petamoriken petamoriken mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lucacasonato @bartlomieju @crowlKats