-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log out which files changed on HMR or watch change #25801
feat: log out which files changed on HMR or watch change #25801
Conversation
@marvinhagemeister |
I'm not really convinced that one can receive "multiple file change". We're restarting on every change and these changes are received one-by-one. I'd encourage to keep single line output and if multifile change happens only use the first one. |
…anAlrimawi/deno into flag-for-serve-watch-and-hmr
@marvinhagemeister |
@HasanAlrimawi thanks for the PR, we'll land it for Deno 2.1. While you're looking into watcher code, could you change the output to make messages after |
…anAlrimawi/deno into flag-for-serve-watch-and-hmr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR addresses issue #25504
Changes
When using
--watch
or--watch-hmr
withdeno serve
, and when usingdeno run --watch
then on any file specified changed, logs will be shown indicating what files changed in a numbered manner.PS: deno run
--watch-hmr
already shows if the script being executed was changed.Screenshot to show the change: