libdirect: remove use of keyword 'register' #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'register' keyword was removed in C++17 and is now unused and reserved. When compiling code that uses DirecthFB with C++17, compilation fails. Since modern compilers likely don't produce different code whether the 'register' keyword is used or not, there shouldn't be any performance impact introduced by this change. Signed-off-by: Simon Barth <[email protected]>
|
|
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 26, 2024
DirectFB explicitly supports usage of C++. With C++17 and later the below
warning is given:
lib/direct/util.h:223:19:
warning: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
223 | register int ret = 0;
| ^~~
To address that, this commit brings in the patch proposed by PR which
removes the usage of the register keyword:
deniskropp/DirectFB#25
Signed-off-by: Ricardo Simoes <[email protected]>
Signed-off-by: Mark Jonas <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Aug 30, 2024
DirectFB explicitly supports usage of C++. With C++17 and later the below
warning is given:
lib/direct/util.h:223:19:
warning: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
223 | register int ret = 0;
| ^~~
To address that, this commit brings in the patch proposed by PR which
removes the usage of the register keyword:
deniskropp/DirectFB#25
Signed-off-by: Ricardo Simoes <ricardo.simoespt.bosch.com>
Signed-off-by: Mark Jonas <mark.jonasde.bosch.com>
Signed-off-by: Khem Raj <raj.khemgmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Sep 5, 2024
DirectFB explicitly supports usage of C++. With C++17 and later the below
warning is given:
lib/direct/util.h:223:19:
warning: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
223 | register int ret = 0;
| ^~~
To address that, this commit brings in the patch proposed by PR which
removes the usage of the register keyword:
deniskropp/DirectFB#25
Signed-off-by: Ricardo Simoes <ricardo.simoespt.bosch.com>
Signed-off-by: Mark Jonas <mark.jonasde.bosch.com>
Signed-off-by: Khem Raj <raj.khemgmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Sep 22, 2024
DirectFB explicitly supports usage of C++. With C++17 and later the below
warning is given:
lib/direct/util.h:223:19:
warning: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
223 | register int ret = 0;
| ^~~
To address that, this commit brings in the patch proposed by PR which
removes the usage of the register keyword:
deniskropp/DirectFB#25
Signed-off-by: Ricardo Simoes <ricardo.simoespt.bosch.com>
Signed-off-by: Mark Jonas <mark.jonasde.bosch.com>
Signed-off-by: Khem Raj <raj.khemgmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'register' keyword was removed in C++17 and is now unused and reserved. When compiling code that uses DirecthFB with C++17, compilation fails.
Since modern compilers likely don't produce different code whether the 'register' keyword is used or not, there shouldn't be any performance impact introduced by this change.