Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize xknob.js #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modernize xknob.js #5

wants to merge 1 commit into from

Conversation

milahu
Copy link

@milahu milahu commented Feb 24, 2021

lets merge the patch from @BramVerb

  • indent with spaces
  • use let, const
  • shorter syntax
  • use class
  • (more?)

maybe split the commit in

  • fix indent
  • use modern JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants