Skip to content

Commit

Permalink
Update auto-approve.md
Browse files Browse the repository at this point in the history
  • Loading branch information
denelon authored Aug 28, 2024
1 parent dd5b04b commit bb9301a
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions doc/spec/auto-approve.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ last updated: <yyyy-mm-dd>
issue id: <github issue id>
---

# Spec Title
# Auto approve new package versions in an allow list

[comment]: # Link to issue: "For [#1](https://github.com/microsoft/winget-pkgs/issues/1)"

Expand Down Expand Up @@ -37,15 +37,16 @@ One moderator can remove a package from the allow list.

## UI/UX Design

[comment]: # What will this fix/feature look like? How will it affect the end user?
PRs for new package versions of packages in the allow list will not require manual review if specific criteria are met.
One of the bots will comment on PRs for these packages if criteria are met for auto-approval. If criteria are not met for auto-approval, the bot will comment with the fields that prevent auto-approval for PRs against packages in the allow list.

## Capabilities

[comment]: # Discuss how the proposed fixes/features impact the following key considerations:

### Accessibility

[comment]: # How will the proposed change impact accessibility for users of screen readers, assistive input devices, etc.
No impact expected

### Security

Expand All @@ -57,10 +58,12 @@ One moderator can remove a package from the allow list.

### Compatibility

[comment]: # Will the proposed change break existing code/behaviors? If so, how, and is the breaking change "worth it"?
No breaking changes are anticipated.

### Performance, Power, and Efficiency

The average time between PR submission and subsequent approval will be reduced on average.

## Potential Issues

[comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted.
Expand Down

0 comments on commit bb9301a

Please sign in to comment.