Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeper Secrets Manager Event Collector #35107

Merged
merged 136 commits into from
Sep 23, 2024
Merged

Conversation

anas-yousef
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-10111

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@yasta5 yasta5 requested a review from OBavly September 18, 2024 10:08
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@anas-yousef anas-yousef merged commit 2936cf3 into master Sep 23, 2024
18 checks passed
@anas-yousef anas-yousef deleted the ay-keeper-event-collector branch September 23, 2024 07:57
sharonfi99 pushed a commit that referenced this pull request Sep 29, 2024
* Init integration

* Moved to right path

* CR fixes

* Deleted files

* Deleted comments

* Dummy

* Trying out SDK

* Stash changes

* Don't throw error

* Deleted if statement

* Added authentication and fetch

* Organized code

* Added docs, refresh token, updated fetch events

* Updated image

* Comment

* Adding unit tests

* Fixed content item suffix

* Testing

* added start and complete command

* Updated desc

* add_time_to_events

* Added demo comments

* Added UTs for registration

* Added docstrings for unit tests

* Deleted aud

* Deleted test_data

* Added README

* Added RNs

* pre-commit

* CR fixes

* Removed ignore

* Fix YML

* Added type: ignore to where needed

* pylint errors

* Added docs to abstract class

* Moved to Keeper Secutiry

* Deleted old integration

* Removed RNs

* Using keeper-security

* Add modeling rules

* Modified README file

* Updated docker tag

* Modified modeling rule

* Modified modeling rule

* Update KeeperSecurity.yml

* Added Keywords and Tags to pack's metadata

---------

Co-authored-by: samuelFain <[email protected]>
Co-authored-by: Yehonatan Asta <[email protected]>
sharonfi99 pushed a commit that referenced this pull request Sep 29, 2024
* Init integration

* Moved to right path

* CR fixes

* Deleted files

* Deleted comments

* Dummy

* Trying out SDK

* Stash changes

* Don't throw error

* Deleted if statement

* Added authentication and fetch

* Organized code

* Added docs, refresh token, updated fetch events

* Updated image

* Comment

* Adding unit tests

* Fixed content item suffix

* Testing

* added start and complete command

* Updated desc

* add_time_to_events

* Added demo comments

* Added UTs for registration

* Added docstrings for unit tests

* Deleted aud

* Deleted test_data

* Added README

* Added RNs

* pre-commit

* CR fixes

* Removed ignore

* Fix YML

* Added type: ignore to where needed

* pylint errors

* Added docs to abstract class

* Moved to Keeper Secutiry

* Deleted old integration

* Removed RNs

* Using keeper-security

* Add modeling rules

* Modified README file

* Updated docker tag

* Modified modeling rule

* Modified modeling rule

* Update KeeperSecurity.yml

* Added Keywords and Tags to pack's metadata

---------

Co-authored-by: samuelFain <[email protected]>
Co-authored-by: Yehonatan Asta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants