Issue #11 🎫: Navigation bar #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require user authentication for all actions. - Add 'current_user' to 'foods#create' action. - Replace notices with flash messages. - Remove 'user_id' from private 'foods#food_params'.
- Also wrap yield in a div with class 'container'.
- _food partial. - _form partial. - index view. - new view.
demesameneshoa
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
STATUS: APPROVED 🟢
Hi @ITurres 👋,
Your ticket 🎟️ is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
To Highlight 🎉
- Good job with Navbar. ✔️
- PR has a good title and summary. ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me with @demesameneshoa in your question so I can receive the notification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary for Issue #11 Completion
🛑 Note: Files and Commits from the previous PR (not yet approved) will be listed as well.
Commits of the changes that were made to complete the issue:
dc2d6f3
Chore: Add project favicon, logo, images-file.3559ef3
Add '_navbar' layout partial.25e1ab3
Feat: add favicon and render 'navbar' partial on application layout.Added:
/app/assets/images/recipes-app-logo-png-favicon.png/app/assets/images/recipes-app-logo-png-large.png/app/assets/images/recipes-app-logo-png-small.png/app/views/layouts/_navbar.html.erbI have added this new layout partial to render the navbar. Which will contain the logo, and conditionally render the login and logout buttons, as well as the
My-Recipes,Foods-ListandShopping-Listlinks.The
Public-Recipeslink will render regardless of the user being logged in or not.🛑 Note:
My-Recipes,Foods-ListandShopping-Listlinks point toroot_pathfor the moment.Modified:
/app/views/layouts/application.html.erbnavbarpartial to theapplicationlayout.headtag.Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟