Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Registration Implementation #17

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Conversation

demesameneshoa
Copy link
Owner

@demesameneshoa demesameneshoa commented Dec 19, 2023

Hello @ITurres Please review the changes included in this PR ↔️

  • Crating devise authentication on User
  • Creating user Sign Up View
  • Implement user confirmation upon registration
  • Storage of hashed password on database

@demesameneshoa demesameneshoa linked an issue Dec 19, 2023 that may be closed by this pull request
@ITurres ITurres added enhancement New feature or request Tests Unit Test and Integration Test UI Views and Interfaces labels Dec 19, 2023
@ITurres ITurres removed the Tests Unit Test and Integration Test label Dec 19, 2023
Copy link
Collaborator

@ITurres ITurres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved! 🟢

Hi @demesameneshoa 🖖🏼

🎉 Your ticket is complete! Go for it and merge it! Congratulations! 🎉

Congratulations Gif 🎉


Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @ITurres in your question so I can receive the notification.

Arthur Iturres

GitHub LinkedIn Slack Email Arthur Iturres Logo

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. gif

@demesameneshoa demesameneshoa merged commit b9acca6 into dev Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI Views and Interfaces
Projects
Development

Successfully merging this pull request may close these issues.

[2pt] - Registration page
2 participants