Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default decorators need not be invoked #2400

Merged
merged 14 commits into from
Dec 31, 2024
Merged

Default decorators need not be invoked #2400

merged 14 commits into from
Dec 31, 2024

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Dec 30, 2024 •
edited
Loading

Closes #2364

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • All tasks in linked issues have been completed or made into separate issues

@lastmjs lastmjs changed the title changing the update decorator to allow @update Default decorators need not be invoked Dec 30, 2024
@lastmjs lastmjs marked this pull request as ready for review December 31, 2024 00:09
@bdemann bdemann self-assigned this Dec 31, 2024
@lastmjs lastmjs merged commit 2815782 into main Dec 31, 2024
366 of 367 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann approved these changes

Assignees

@bdemann bdemann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should we make params optional in the decorators? What if we allowed just @update() or even just @update?
2 participants
@lastmjs @bdemann