-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rust #2398
Merged
Merged
update rust #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdemann
commented
Dec 30, 2024
•
edited by lastmjs
Loading
edited by lastmjs
- Breaking changes enumerated in the release issue (breaking changes need to be added to the issue, at least .raw)
- New documentation enumerated in the release issue (at least the .raw stuff needs to be added to documentation, should be added to the issue)
- Code has been declaratized
- Error handling beautiful (no unwraps or expects etc)
- Code tested thoroughly (dfx will automatically have tests run against it, and node to some extent...but how are we testing wasi2ic and rust? We would have to simply run those locally and create new templates right? I assume that's what you did?)
- All new functions have JSDoc/Rustdoc comments
- All tasks in linked issues have been completed or made into separate issues
bdemann
force-pushed
the
update_global_dependencies
branch
from
December 30, 2024 19:46
b633cbb
to
9fa3f6d
Compare
bdemann
force-pushed
the
update_global_dependencies
branch
from
December 31, 2024 00:06
1bcaeb3
to
d597126
Compare
lastmjs
previously approved these changes
Dec 31, 2024
5 tasks
|
you may be interested in reading this issue #2403 |
bdemann
force-pushed
the
update_global_dependencies
branch
from
December 31, 2024 14:32
e48db13
to
54fd34b
Compare
lastmjs
previously approved these changes
Dec 31, 2024
lastmjs
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.