Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rust #2398

Merged
merged 13 commits into from
Dec 31, 2024
Merged

update rust #2398

merged 13 commits into from
Dec 31, 2024

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Dec 30, 2024

  • Breaking changes enumerated in the release issue (breaking changes need to be added to the issue, at least .raw)
  • New documentation enumerated in the release issue (at least the .raw stuff needs to be added to documentation, should be added to the issue)
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly (dfx will automatically have tests run against it, and node to some extent...but how are we testing wasi2ic and rust? We would have to simply run those locally and create new templates right? I assume that's what you did?)
  • All new functions have JSDoc/Rustdoc comments
  • All tasks in linked issues have been completed or made into separate issues

@bdemann bdemann force-pushed the update_global_dependencies branch from b633cbb to 9fa3f6d Compare December 30, 2024 19:46
@bdemann bdemann force-pushed the update_global_dependencies branch from 1bcaeb3 to d597126 Compare December 31, 2024 00:06
@bdemann bdemann marked this pull request as ready for review December 31, 2024 00:38
lastmjs
lastmjs previously approved these changes Dec 31, 2024
@bdemann bdemann linked an issue Dec 31, 2024 that may be closed by this pull request
5 tasks
@bdemann
Copy link
Member Author

bdemann commented Dec 31, 2024

  • .raw has been added to documentation and breaking change. Note: that's only a breaking change if we can get the dfx version updated.
  • You're assumptions about the building templates to test rust and wasi2ic are correct. As I was double checking I realized that I had not built the template after updating wasi2ic. I have updated that. Strangely the template didn't change after that update...

@bdemann
Copy link
Member Author

bdemann commented Dec 31, 2024

you may be interested in reading this issue #2403

@bdemann bdemann force-pushed the update_global_dependencies branch from e48db13 to 54fd34b Compare December 31, 2024 14:32
lastmjs
lastmjs previously approved these changes Dec 31, 2024
@lastmjs lastmjs merged commit c3f15d8 into main Dec 31, 2024
366 checks passed
@bdemann bdemann deleted the update_global_dependencies branch January 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update all of our own global dependencies
2 participants