Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICP API prop test types #2305

Merged
merged 17 commits into from
Dec 11, 2024
Merged

ICP API prop test types #2305

merged 17 commits into from
Dec 11, 2024

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Dec 6, 2024 •
edited
Loading

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly

@bdemann bdemann force-pushed the icp_api_prop_test_types branch 3 times, most recently from 8808444 to a71dca4 Compare December 10, 2024 23:09
@bdemann bdemann force-pushed the icp_api_prop_test_types branch from a71dca4 to dd19c43 Compare December 10, 2024 23:25
lastmjs
lastmjs requested changes Dec 11, 2024
View reviewed changes
tests/property/ic_api/arg_data_raw/test/tests.ts Outdated Show resolved Hide resolved
tests/property/ic_api/certified_data/src/index.ts Show resolved Hide resolved
tests/property/ic_api/certified_data/test/tests.ts Outdated Show resolved Hide resolved
tests/property/ic_api/certified_data/test/tests.ts Outdated Show resolved Hide resolved
tests/property/ic_api/cycles/src/intermediary/index.ts Show resolved Hide resolved
tests/property/ic_api/cycles_burn/src/index.ts Outdated Show resolved Hide resolved
tests/property/ic_api/cycles_burn/test/tests.ts Outdated Show resolved Hide resolved
tests/property/ic_api/performance_counter/src/index.ts Show resolved Hide resolved
tests/property/ic_api/reject_code/src/caller/index.ts Outdated Show resolved Hide resolved
lastmjs
lastmjs previously approved these changes Dec 11, 2024
View reviewed changes
@lastmjs lastmjs merged commit 54cb7ce into main Dec 11, 2024
364 checks passed
@bdemann bdemann linked an issue Dec 16, 2024 that may be closed by this pull request
Make tests to ensure all ic api types (esp return types) are what they say they are #2304
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tests to ensure all ic api types (esp return types) are what they say they are
2 participants
@bdemann @lastmjs