Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class based prop tests up to float #2006

Closed

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Aug 20, 2024

No description provided.

@bdemann bdemann changed the base branch from main to class_based_prop_test_arbs August 20, 2024 15:42
"node_compatibility": true
},
"custom": {
"experimental": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental must be removed from all class-based examples if possible

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

},
"devDependencies": {
"tsx": "^4.15.7",
"typescript": "^5.2.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get rid of typescript and see if that works? If it works, can you remove it from all property tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bdemann bdemann requested a review from lastmjs August 20, 2024 21:57
@bdemann bdemann closed this Aug 23, 2024
@bdemann bdemann deleted the class_based_prop_tests_up_to_float branch August 23, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants