Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite queries #1851

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Composite queries #1851

merged 3 commits into from
Jul 8, 2024

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jun 21, 2024

No description provided.

@lastmjs lastmjs changed the base branch from stable_canister_api to main June 24, 2024 16:39
@bdemann bdemann changed the base branch from main to cross_cansiter_calls June 24, 2024 22:46
bdemann
bdemann previously approved these changes Jun 24, 2024
View reviewed changes
@bdemann bdemann changed the base branch from cross_cansiter_calls to main June 24, 2024 22:49
@bdemann bdemann dismissed their stale review June 24, 2024 22:49

The base branch was changed.

bdemann
bdemann requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@bdemann bdemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the failing tests everything looks good

@lastmjs lastmjs merged commit 9905546 into main Jul 8, 2024
134 of 138 checks passed
@lastmjs lastmjs deleted the composite_queries branch July 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lastmjs @bdemann