Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement cross_canister_calls example, notify, trap #1850

Merged
merged 2 commits into from
Jul 8, 2024
Merged

implement cross_canister_calls example, notify, trap #1850

merged 2 commits into from
Jul 8, 2024

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jun 20, 2024

No description provided.

@lastmjs lastmjs marked this pull request as ready for review June 20, 2024 18:42
@lastmjs lastmjs requested a review from bdemann June 20, 2024 18:42
bdemann
bdemann previously approved these changes Jun 20, 2024
View reviewed changes
@lastmjs lastmjs changed the base branch from stable_canister_api to main June 24, 2024 16:39
@lastmjs lastmjs dismissed bdemann’s stale review June 24, 2024 16:39

The base branch was changed.

bdemann
bdemann requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@bdemann bdemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests should be easy to fix, it looks like you still just have an import for the ic object that is tripping you up

@lastmjs lastmjs merged commit 1f479e7 into main Jul 8, 2024
136 of 140 checks passed
@lastmjs lastmjs deleted the cross_cansiter_calls branch July 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lastmjs @bdemann