Improve terminal error output #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1752
I've introduced an
execSyncPrettyfunction to be used in place ofexecSync. This will catch the default error output and create a much nicer terminal output for the developer. It has a default stack trace and should be quite practical. Not the most beautiful still, we might want to improve it in the future, but it should be much better than what currently happens.What currently happens is confusing and verbose, it logs stdout, stderr, with a lot of Uint8Arrays or buffers or such, and it is generally scary-looking and not helpful.
That has hopefully been fixed or greatly improved with this PR.