Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New eslint #1733

Merged
merged 37 commits into from
Apr 11, 2024
Merged

New eslint #1733

merged 37 commits into from
Apr 11, 2024

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Apr 4, 2024

Important

For more information check out the original PR #1458

Note

I am expecting that all of the tests will fail because the auto sort imports is not part of this pr. We have a couple of options.

  1. We can merge this in with confidence that Auto fix all file imports with #1734 will fix those linting problems
  2. We can finish the review, finish Auto fix all file imports with #1734, merge Auto fix all file imports with #1734 into this and then rerun the tests
  3. We could move the commits where we run the linter in CI/CD to a third PR.
  4. We could just bring it all back into one PR

This was referenced Apr 4, 2024
lastmjs
lastmjs previously approved these changes Apr 10, 2024
lastmjs
lastmjs previously approved these changes Apr 10, 2024
@lastmjs lastmjs merged commit df1cb6d into main Apr 11, 2024
120 of 123 checks passed
@bdemann bdemann deleted the new_eslint branch April 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants