Tfjs #1705
Merged
Tfjs #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an additional test for
file://in fetch, and to show a solution to a problem that a dev has wanted since ETH Denver, I have created a TensorFlow.js example that loads a basic model. The loading of TensorFlow.js uses fetch andfile://under-the-hood. We weren't able to easily figure out any other way of doing this, and thus the motivation for implementing thefile://protocol in fetch.It is still somewhat unclear how TensorFlow.js has been working in Node, considering from our research it seems
file://is not yet implemented. Perhaps they have their own or some kind of modified library version of fetch that they've been using.The TensorFlow.js example is not completely finished, as the model does not produce inference. I am okay with that for now, it at least loads the model and goes to the filesystem for that. In the future we can improve this example or create other TensorFlow.js examples with more advanced AI use cases.