Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch #1596

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Fetch #1596

merged 10 commits into from
Jan 31, 2024

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jan 30, 2024

No description provided.

@bdemann bdemann marked this pull request as draft January 31, 2024 00:27
@lastmjs lastmjs marked this pull request as ready for review January 31, 2024 00:46
{
body: serialize({
candidPath: 'canister2/index.did',
args: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid of empty args here and above as well

return responseJson;
} else {
return await ic.call(canister2.accounts, {
args: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@lastmjs lastmjs merged commit ac9943b into main Jan 31, 2024
108 checks passed
@lastmjs lastmjs deleted the fetch branch February 6, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants