Add Recursive Arbs #1515
Merged
Add Recursive Arbs #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemann
force-pushed
the
cherry-rec
branch
4 times, most recently
from
37706d2 to
92b8ed4
Compare
bdemann
force-pushed
the
cherry-rec
branch
2 times, most recently
from
5456696 to
3b59d9b
Compare
lastmjs
requested changes
Jan 9, 2024
property_tests/arbitraries/candid/candid_value_and_meta_arb_generator.ts
Outdated
Show resolved
Hide resolved
property_tests/arbitraries/candid/candid_definition_arb/simple_candid_definition_arb.ts
Outdated
Show resolved
Hide resolved
property_tests/arbitraries/candid/constructed/opt_arb/definition_arb.ts
Outdated
Show resolved
Hide resolved
property_tests/arbitraries/candid/constructed/variant_arb/definition_arbs.ts
Outdated
Show resolved
Hide resolved
lastmjs
requested changes
Jan 16, 2024
lastmjs
requested changes
Jan 18, 2024
property_tests/arbitraries/candid/candid_value_and_meta_arb_generator.ts
Outdated
Show resolved
Hide resolved
property_tests/arbitraries/candid/reference/service_arb/definition_arb.ts
Outdated
Show resolved
Hide resolved
|
Add two ways of repeating tests for the recursive test memory issues. Create issue to look into causes and disadvantages and come up with a better solution |
lastmjs
approved these changes
Jan 18, 2024
This was referenced Jan 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.