Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use stableJson everywhere #1485

Merged
merged 2 commits into from
Dec 8, 2023
Merged

use stableJson everywhere #1485

merged 2 commits into from
Dec 8, 2023

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Dec 8, 2023

No description provided.

@lastmjs lastmjs marked this pull request as ready for review December 8, 2023 20:48
dansteren
dansteren approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@dansteren dansteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! Just make sure to add documentation :)

@dansteren dansteren added the breaking change This PR contains a breaking change label Dec 8, 2023
@lastmjs lastmjs merged commit 01a4005 into main Dec 8, 2023
96 checks passed
@lastmjs lastmjs deleted the use_stable_json_everywhere branch February 10, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansteren dansteren dansteren approved these changes

Assignees
No one assigned
Labels
breaking change This PR contains a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lastmjs @dansteren