Property test vec new approach #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_threshold
…ree_map_performance_tests
This ensures we have trailing newlines and no trailing whitespace.
All team members should install these extensions if using VS Code.
bdemann
force-pushed
the
property_test_vec_new_approach
branch
2 times, most recently
from
b78ca38 to
5b291d7
Compare
bdemann
commented
Dec 1, 2023
bdemann
force-pushed
the
property_test_vec_new_approach
branch
from
c969ae4 to
5274f06
Compare
dansteren
suggested changes
Dec 1, 2023
property_tests/arbitraries/candid/constructed/blob_arb/definition.ts
Outdated
Show resolved
Hide resolved
property_tests/arbitraries/candid/constructed/blob_arb/values.ts
Outdated
Show resolved
Hide resolved
property_tests/arbitraries/candid/constructed/variant_arb/definition_arbs.ts
Show resolved
Hide resolved
…mance_tests Stable b tree map performance tests
lastmjs
requested changes
Dec 1, 2023
|
|
||
| export const BoolArb = CandidMetaArb(fc.boolean(), 'bool', booleanToSrcLiteral); | ||
| export const BoolArb = SimpleCandidValueAndMetaArb( |
There was a problem hiding this comment.
SimpleCandidValueAndMetaArb should cease to exist and be replaced with ComplexCandidValueAndMetaArb...rename it to CandidValueAndMetaArbCreator or something
Reduced code duplication across query method tests
Add VS Code Extensions and Editorconfig
(vec and record are working with typeDeclarations)
More refactoring
and CandidValueArb
bdemann
force-pushed
the
property_test_vec_new_approach
branch
from
cf2b8df to
047e96b
Compare
lastmjs
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.