Eslint fixes #1460
Closed
Eslint fixes #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansteren
force-pushed
the
eslint_fixes
branch
2 times, most recently
from
6c9c977 to
458e5eb
Compare
The remainder are largely from the primitive_ops example, JS Doc comments, and our crazy type declarations.
dansteren
force-pushed
the
eslint_fixes
branch
from
458e5eb to
7489041
Compare
lastmjs
requested changes
Dec 1, 2023
This way we can hover over them to see the types.
|
Closing in favor of #1735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fixes for 10 of the offending eslint rules reducing us down to only 8 tech-debt disabled rules.
Caution
Change the base of this PR to main before merging and more the ESLint PR first.