Add VS Code Extensions and Editorconfig #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we have trailing newlines and no trailing whitespace.
All team members should install these extensions if using VS Code.
lastmjs
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorconfig
We currently don't have anything to ensure consistent formatting of our files. Editorconfig is an industry standard for ensuring that consistency across different editor types. This adds a config that matches our repo and removes it from the gitignore.
Important
We've already run into issues with formatting in the past. See #550 (comment).
VS Code Extension Recommendations
All devs now need to install some extensions in order for tools to work correctly. This adds a recommended list of extensions so that new devs will be prompted to install these. This does not include personal favorites. Devs are not required to install these. I.e. I don't see any downside to adding this.