Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor CandidType and Serializable #1447

Merged
merged 3 commits into from
Nov 9, 2023
Merged

refactor CandidType and Serializable #1447

merged 3 commits into from
Nov 9, 2023

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Nov 9, 2023

No description provided.

@lastmjs lastmjs marked this pull request as ready for review November 9, 2023 20:38
dansteren
dansteren approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@dansteren dansteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think the throw should be documented before this is merged. That being said, it wasn't technically part of this PR, so I've gone ahead and approved it anyway. I just don't want us to forget.

And for the other stuff just choose what you think is best.

src/lib/stable_structures/stable_b_tree_map.ts Show resolved Hide resolved
src/lib/stable_structures/stable_b_tree_map.ts Show resolved Hide resolved
src/lib/stable_structures/stable_b_tree_map.ts Show resolved Hide resolved
@lastmjs
Copy link
Member Author

lastmjs commented Nov 9, 2023

I'm still working on StableBTreeMap so this kind of documentation isn't really what I was focusing on

@lastmjs lastmjs merged commit f27874e into main Nov 9, 2023
95 checks passed
@lastmjs lastmjs deleted the stable_json branch February 10, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansteren dansteren dansteren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lastmjs @dansteren