refactor js rearchitecture code #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemann
force-pushed
the
js_refactor
branch
2 times, most recently
from
632dcec to
a96cd1a
Compare
lastmjs
requested changes
Oct 18, 2023
bdemann
force-pushed
the
js_refactor
branch
2 times, most recently
from
f35ad89 to
0f2579c
Compare
lastmjs
requested changes
Oct 18, 2023
lastmjs
requested changes
Oct 18, 2023
|
serde visitors should look like did_file visitor, each visitor should have its own file in a folder called visit |
Done |
lastmjs
approved these changes
Oct 18, 2023
|
Hi, after this change made 3 weeks ago: 
The return type of 
if I comment out this 3 lines of code, it is back to normal: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.