Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated robust imports example to functional runtime syntax #1291

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Updated robust imports example to functional runtime syntax #1291

merged 4 commits into from
Sep 27, 2023

Conversation

dansteren
Copy link
Contributor

@dansteren dansteren commented Sep 27, 2023 •
edited
Loading

Additionally removes all opt_level code.

Closes #1237

@dansteren
Update robust_imports to functional runtime syntax
d4dbfc0
@dansteren
Remove opt_level from DFX configuration
0bec2a3 
With the functional runtime syntax this is no longer necessary nor
supported.
@dansteren dansteren changed the base branch from main to js_rearchitecture September 27, 2023 06:33
This was linked to issues Sep 27, 2023
Remove all opt levels from examples #1277
Closed
Rewrite the robust_imports example #1237
Closed
@lastmjs lastmjs marked this pull request as ready for review September 27, 2023 16:07
@lastmjs lastmjs merged commit bff5195 into js_rearchitecture Sep 27, 2023
@dansteren dansteren deleted the robust_imports_functional_syntax branch October 4, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all opt levels from examples Rewrite the robust_imports example
2 participants
@dansteren @lastmjs