Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated more examples to new syntax #1212

Merged
merged 23 commits into from
Sep 11, 2023
Merged

Updated more examples to new syntax #1212

merged 23 commits into from
Sep 11, 2023

Conversation

dansteren
Copy link
Contributor

@dansteren dansteren commented Sep 7, 2023 •
edited
Loading

Updates the following examples:

  • ic_api
  • motoko_examples/phone-book
  • motoko_examples/simple-to-do
  • motoko_examples/whoami
  • timers
  • rejections

Closes #1210

@dansteren dansteren force-pushed the 1210_more_examples branch 5 times, most recently from 634c4fc to cfd13fc Compare September 9, 2023 00:09
@dansteren
Update canister syntax
b32ac5d
@dansteren
Rename entrypoint
153232d
@dansteren
Update dependencies
50caa70
@dansteren
Fix argDataRaw
53e0d53
@dansteren
Add data_certificate API
c4ca45a
@dansteren
Fix is controller
2db5d00 
The changes to is_controller.rs are purely formatting changes. The fix
is passing the inner buffer down, rather than the whole Uint8Array
@dansteren
Get all tests except reject passing
bf38d1e 
Reject requires the work for manual replies to be done.
@dansteren
Remove extraneous decorators
a33ca46
@dansteren
Remove extraneous decorators from some examples
be59485
@dansteren
Re-add simple-to-do & phone-book examples to CI/CD
0fa71c2
@dansteren
Update whoami example
b22c8e2
@dansteren
Rewrite timers example
ae0ee99 
Note: Does not yet work. The underlying API calls haven't been hooked up
@dansteren
Get set timer hooked up to call a rust closure
2a19663
@dansteren
Add rough setTimerInterval boilerplate
58b261e 
Still needs to actually call the callback they passed in.
@dansteren
Attempt to hookup callback
6a6744d 
But it's an object not a function... ;(
@dansteren
Get timers tests passing!
af31654
@dansteren
Improve timers in non-happy-path cases
0cd809c
@dansteren
Re-enable timers in CI/CD
a6fb236
@dansteren
Fix memory leaks in clear_timer
0690ef3
@dansteren
Rename entry points
2ed552f
@dansteren
Update syntax
dbea089
@dansteren dansteren force-pushed the 1210_more_examples branch 2 times, most recently from d8be4a8 to d202174 Compare September 11, 2023 18:33
@dansteren dansteren requested a review from bdemann September 11, 2023 18:33
@dansteren dansteren marked this pull request as ready for review September 11, 2023 18:33
@dansteren dansteren linked an issue Sep 11, 2023 that may be closed by this pull request
Finish updating examples to Runtimize syntax #1210
Closed
7 tasks
bdemann
bdemann requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@bdemann bdemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove that manual stuff from my other review

@dansteren dansteren requested a review from bdemann September 11, 2023 19:41
@bdemann bdemann merged commit fc20797 into js_rearchitecture Sep 11, 2023
49 checks passed
@dansteren dansteren deleted the 1210_more_examples branch September 11, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finish updating examples to Runtimize syntax
2 participants
@dansteren @bdemann