Replace cast types with generic type params

demergent-labs · Dec 18, 2023 · ac362cc · ac362cc
1 parent 9cab790
commit ac362cc
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 18 deletions.
diff --git a/property_tests/arbitraries/candid/reference/func_arb/definition_arb.ts b/property_tests/arbitraries/candid/reference/func_arb/definition_arb.ts
@@ -12,7 +12,8 @@ type Mode = 'query' | 'update' | 'oneway';
 export function FuncDefinitionArb(
     candidDefArb: fc.Arbitrary<CandidDefinition>
 ): fc.Arbitrary<FuncCandidDefinition> {
-    return (fc.constantFrom('query', 'update', 'oneway') as fc.Arbitrary<Mode>)
+    return fc
+        .constantFrom<Mode>('query', 'update', 'oneway')
         .chain((mode) => {
             const returnType =
                 mode === 'oneway' ? VoidDefinitionArb() : candidDefArb;

diff --git a/property_tests/arbitraries/candid/reference/service_arb/service_method_arb.ts b/property_tests/arbitraries/candid/reference/service_arb/service_method_arb.ts
@@ -26,7 +26,7 @@ export function ServiceMethodArb(
     return fc
         .tuple(
             JsFunctionNameArb,
-            fc.constantFrom('query', 'update') as fc.Arbitrary<Mode>,
+            fc.constantFrom<Mode>('query', 'update'),
             fc.array(candidDefArb),
             fc.oneof(candidDefArb, VoidDefinitionArb())
         )

diff --git a/property_tests/arbitraries/canister_methods/init_method_arb.ts b/property_tests/arbitraries/canister_methods/init_method_arb.ts
@@ -51,10 +51,7 @@ export function InitMethodArb<
             UniqueIdentifierArb('canisterMethod'),
             paramTypeArrayArb,
             VoidArb(),
-            fc.constantFrom(
-                'INLINE',
-                'STANDALONE'
-            ) as fc.Arbitrary<CallbackLocation>,
+            fc.constantFrom<CallbackLocation>('INLINE', 'STANDALONE'),
             UniqueIdentifierArb('typeDeclaration')
             // TODO: This unique id would be better named globalScope or something
             // But needs to match the same scope as typeDeclarations so I'm using

diff --git a/property_tests/arbitraries/canister_methods/post_upgrade_arb.ts b/property_tests/arbitraries/canister_methods/post_upgrade_arb.ts
@@ -51,10 +51,7 @@ export function PostUpgradeMethodArb<
             UniqueIdentifierArb('canisterMethod'),
             paramTypeArrayArb,
             VoidArb(),
-            fc.constantFrom(
-                'INLINE',
-                'STANDALONE'
-            ) as fc.Arbitrary<CallbackLocation>,
+            fc.constantFrom<CallbackLocation>('INLINE', 'STANDALONE'),
             UniqueIdentifierArb('typeDeclaration')
             // TODO: This unique id would be better named globalScope or something
             // But needs to match the same scope as typeDeclarations so I'm using

diff --git a/property_tests/arbitraries/canister_methods/query_method_arb.ts b/property_tests/arbitraries/canister_methods/query_method_arb.ts
@@ -57,10 +57,7 @@ export function QueryMethodArb<
             UniqueIdentifierArb('canisterMethod'),
             paramTypeArrayArb,
             returnTypeArb,
-            fc.constantFrom(
-                'INLINE',
-                'STANDALONE'
-            ) as fc.Arbitrary<CallbackLocation>,
+            fc.constantFrom<CallbackLocation>('INLINE', 'STANDALONE'),
             UniqueIdentifierArb('typeDeclaration')
             // TODO: This unique id would be better named globalScope or something
             // But needs to match the same scope as typeDeclarations so I'm using

diff --git a/property_tests/arbitraries/canister_methods/update_method_arb.ts b/property_tests/arbitraries/canister_methods/update_method_arb.ts
@@ -58,10 +58,7 @@ export function UpdateMethodArb<
             UniqueIdentifierArb('canisterMethod'),
             paramTypeArrayArb,
             returnTypeArb,
-            fc.constantFrom(
-                'INLINE',
-                'STANDALONE'
-            ) as fc.Arbitrary<CallbackLocation>,
+            fc.constantFrom<CallbackLocation>('INLINE', 'STANDALONE'),
             UniqueIdentifierArb('typeDeclaration')
             // TODO: This unique id would be better named globalScope or something
             // But needs to match the same scope as typeDeclarations so I'm using