pr fixes

demergent-labs · Oct 23, 2023 · 9eb8c99 · 9eb8c99
1 parent eba5eed
commit 9eb8c99
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -131,6 +131,7 @@ jobs:
                     "examples/update",
                     "examples/vanilla_js",
                     "property_tests/tests/blob",
+                    "property_tests/tests/bool",
                     "property_tests/tests/int",
                     "property_tests/tests/int8",
                     "property_tests/tests/int16",

diff --git a/property_tests/arbitraries/candid/primitive/bool.ts b/property_tests/arbitraries/candid/primitive/bool.ts
@@ -0,0 +1,3 @@
+import fc from 'fast-check';
+
+export const BoolArb = fc.boolean();
diff --git a/property_tests/tests/bool/src/.gitkeep b/property_tests/tests/bool/src/.gitkeep
diff --git a/property_tests/tests/bool/test/test.ts b/property_tests/tests/bool/test/test.ts
@@ -3,26 +3,25 @@ import { getCanisterId } from '../../../../test';
 import { createUniquePrimitiveArb } from '../../../arbitraries/unique_primitive_arb';
 import { JsFunctionNameArb } from '../../../arbitraries/js_function_name_arb';
 import { runPropTests } from '../../..';
+import { BoolArb } from '../../../arbitraries/candid/primitive/bool';
 
 const BoolTestArb = fc
-    .tuple(createUniquePrimitiveArb(JsFunctionNameArb), fc.array(fc.boolean()))
+    .tuple(createUniquePrimitiveArb(JsFunctionNameArb), fc.array(BoolArb))
     .map(([functionName, bools]) => {
         const paramCandidTypes = bools.map(() => 'bool').join(', ');
         const returnCandidType = 'bool';
         const paramNames = bools.map((_, index) => `param${index}`);
 
-        const paramsAreNumbers = paramNames
+        const paramsAreBooleans = paramNames
             .map((paramName) => {
                 return `if (typeof ${paramName} !== 'boolean') throw new Error('${paramName} must be a boolean');`;
             })
             .join('\n');
 
-        const paramsAnd = paramNames.reduce((acc, paramName) => {
+        const returnStatement = paramNames.reduce((acc, paramName) => {
             return `${acc} && ${paramName}`;
         }, 'true');
 
-        const returnStatement = `${paramsAnd}`;
-
         const expectedResult = bools.reduce((acc, bool) => acc && bool, true);
 
         const paramSamples = bools;
@@ -43,7 +42,7 @@ const BoolTestArb = fc
             body: `
             ${paramsCorrectlyOrdered}
 
-            ${paramsAreNumbers}
+            ${paramsAreBooleans}
 
             return ${returnStatement};
         `,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import fc from 'fast-check';

		export const BoolArb = fc.boolean();