pass node version to get_test_infos

demergent-labs · Sep 17, 2024 · 71c5cae · 71c5cae
1 parent 41db2e7
commit 71c5cae
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/.github/actions/get_test_infos/action.yml b/.github/actions/get_test_infos/action.yml
@@ -9,17 +9,16 @@ description:
     displayPath: string // An abbreviated version of the path for display purposes only
     }'
 inputs:
+    node-version:
+        description: The version of Node.js to use
+        required: true
     directories:
         description: List of directories to search for npm projects with an npm test script
         required: true
     exclude-dirs:
         description: List of directories to exclude from the search
         required: false
         default: ''
-    node-version:
-        description: The version of Node.js to use
-        required: true
-        default: '20.x'
 outputs:
     test-infos:
         description: All of the test info objects found by this action

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -33,7 +33,9 @@ jobs:
               run: echo ${{steps.get-node-version.outputs.node-version}}
 
     get-test-infos:
-        needs: determine-should-release
+        needs:
+            - determine-should-release
+            - get-node-version
         if: ${{ startsWith(github.head_ref, 'release--') && needs.determine-should-release.outputs.should-release }}
         name: Get test infos
         runs-on: ubuntu-latest
@@ -46,6 +48,7 @@ jobs:
               id: get-test-infos
               uses: ./.github/actions/get_test_infos
               with:
+                  node-version: ${{ needs.get-node-version.outputs.node-version }}
                   directories: |
                       ./examples
                       ./tests

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -36,12 +36,12 @@ jobs:
 
             - id: get-node-version
               uses: ./.github/actions/get_node_version
-            - id: report
-              run: echo ${{steps.get-node-version.outputs.node-version}}
 
     get-test-infos:
         name: Get test infos
-        needs: determine-should-run-tests
+        needs:
+            - determine-should-run-tests
+            - get-node-version
         if: ${{ needs.determine-should-run-tests.outputs.should-run-tests == 'true' }}
         runs-on: ubuntu-latest
         outputs:
@@ -53,6 +53,7 @@ jobs:
               id: get-test-infos
               uses: ./.github/actions/get_test_infos
               with:
+                  node-version: ${{ needs.get-node-version.outputs.node-version }}
                   directories: |
                       ./examples
                       ./tests