Merge pull request #2384 from demergent-labs/dependabot/cargo/rquickj…

…s-0.8.1 deps: bump rquickjs from 0.6.2 to 0.8.1
demergent-labs · Dec 31, 2024 · 697a8a9 · 697a8a9
2 parents b046c7a + 49aebda
commit 697a8a9
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 36 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/canister_templates/stable.wasm b/canister_templates/stable.wasm
diff --git a/examples/stable/test/property/ic_api/chunk/src/index.ts b/examples/stable/test/property/ic_api/chunk/src/index.ts
@@ -47,7 +47,7 @@ async function sum(loops: number, shouldChunk: boolean): Promise<void> {
     for (let i = 0; i < loops; i++) {
         _sum += (i % 100) * (i % 100);
 
-        if (shouldChunk && i % 15_000_000 === 0) {
+        if (shouldChunk && i % 14_000_000 === 0) {
             await chunk();
         }
     }

diff --git a/examples/stable/test/property/ic_api/chunk/test/tests.ts b/examples/stable/test/property/ic_api/chunk/test/tests.ts
@@ -58,6 +58,9 @@ export function getTests(): Test {
             );
         });
 
+        // TODO this test will simply hang if it fails because timers don't throw any errors that we can catch
+        // TODO we would need to use the canister logs somehow to check if the timer has hit its instruction limit
+        // TODO but see this issue: https://forum.dfinity.org/t/no-instruction-limit-hit-canister-logs-within-timer/39518
         it('should not hit the instruction limit with chunking in a timer', async () => {
             const actor = await getCanisterActor<Actor>('canister');
 

diff --git a/src/build/stable/commands/compile/wasm_binary/rust/stable_canister_template/Cargo.toml b/src/build/stable/commands/compile/wasm_binary/rust/stable_canister_template/Cargo.toml
@@ -14,7 +14,7 @@ ic-cdk-macros = "0.17.1"
 ic-cdk-timers = "0.11.0"
 ic-stable-structures = "0.6.7"
 ic-wasi-polyfill = "0.6.4"
-rquickjs = { version = "0.6.2", features = ["array-buffer", "bindgen"] }
+rquickjs = { version = "0.8.1", features = ["array-buffer", "bindgen"] }
 scopeguard = "1.2.0"
 serde = "1.0.217"
 serde_json = "1.0.134"